Skip to content

Hardening suggestions for PythonBatchSept2024 / class30 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixeebot wants to merge 1 commit into
base: class30
Choose a base branch
from
Open

Hardening suggestions for PythonBatchSept2024 / class30 #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions 13_OOP/e_DataClasses/04_data_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import random
from dataclasses import dataclass, field
import secrets


def random_price():
return random.randint(20, 100)
return secrets.SystemRandom().randint(20, 100)
Copy link
Copy Markdown
Author

@pixeebot pixeebot Bot Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace random.{func} with more secure secrets library functions.



@dataclass
Expand All @@ -25,4 +25,4 @@ class Book(object):
# thus, provides the value dynamically, when the new instance is created.

c = Book("Python programming", "David Beazley", 45)
print(vars(c))
print(vars(c))