Improve RunnableParameterizable - #574
Open
MarcusZuber wants to merge 4 commits into
Open
Conversation
- Move as much code from Director/Experiment to RunnableParameterizable - Add early_prepare/late_finish (outside logging) - Make Acquisitions also RunnableParameterizablef with same interface
MarcusZuber
force-pushed
the
improve-RunnableParameterizable
branch
from
August 6, 2026 12:25
87b3ea6 to
59724fb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 83.45% 83.58% +0.12%
==========================================
Files 136 137 +1
Lines 11279 11330 +51
==========================================
+ Hits 9413 9470 +57
+ Misses 1866 1860 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I want to generalize the DirectorExperiment/Acquisitions/RunnableParameterizable a bit.
Logging in now handles the same way in all RunnableParameterizable. This also allows to seamlessly nest Directors.
Acquisitions, Experiments and Directors now have the same interface.