Skip to content

stop looping request due HTTPInternalServerError #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nepod1988 wants to merge 1 commit into
base: quick-n-dirty-redo-request-if-error-is-temporary-rails-4-plus
Choose a base branch
from
Open

stop looping request due HTTPInternalServerError #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions lib/shopify_api/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,19 @@ def notify_about_request(response, arguments)

module RedoIfTemporaryError
def request(*args)
binding.pry
super
rescue ActiveResource::ClientError, ActiveResource::ServerError => e
if should_retry? && e.response.class.in?([Net::HTTPTooManyRequests, Net::HTTPInternalServerError])
wait
request *args
if e.response.class.in?([Net::HTTPTooManyRequests])
wait
request *args
else
sleep 30
increase_server_error_counter
raise if server_error_counter == 10
request *args
end
else
raise
end
Expand All @@ -49,6 +57,14 @@ def wait
def should_retry?
[true, nil].include? Thread.current[:retry_temporary_errors]
end

def increase_server_error_counter
@server_error_counter = server_error_counter + 1
end

def server_error_counter
@server_error_counter ||= 0
end
end

include RedoIfTemporaryError
Expand Down