Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,27 @@ jobs:
with:
dotnet-version: '10.x'

# ── Guard: WiX must reference every file in src/CodeShellManager/Assets.
# Portable ZIP ships the whole publish output, so this only bites MSI users
# (e.g. v0.4.1 silently dropped terminal-init.js → blank terminals).
- name: Verify WiX manifest covers all Assets files
shell: pwsh
run: |
$assetFiles = (Get-ChildItem 'src/CodeShellManager/Assets' -File).Name | Sort-Object
$wxs = Get-Content 'installer/CodeShellManager.wxs' -Raw
$matches = [regex]::Matches($wxs, '\$\(var\.PublishDir\)\\Assets\\([^"]+)')
$wxsRefs = ($matches | ForEach-Object { $_.Groups[1].Value } | Sort-Object -Unique)
$diff = Compare-Object $assetFiles $wxsRefs
if ($diff) {
Write-Host "::error::installer/CodeShellManager.wxs is out of sync with src/CodeShellManager/Assets/"
$diff | ForEach-Object {
$side = if ($_.SideIndicator -eq '<=') { 'missing from WiX' } else { 'not present in Assets/' }
Write-Host " $($_.InputObject) — $side"
}
exit 1
}
Write-Host "WiX/Assets in sync ($($assetFiles.Count) files)"

# ── Build (every push / PR) ──────────────────────────────────────────────
- name: Restore & Build
run: dotnet build src/CodeShellManager/CodeShellManager.csproj -c Release
Expand Down
10 changes: 9 additions & 1 deletion installer/CodeShellManager.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,18 @@
<File Source="$(var.PublishDir)\Assets\app.ico" KeyPath="yes" />
</Component>

<!-- Assets — one component per file so auto-GUID works -->
<!-- Assets — one component per file so auto-GUID works.
If you add a new file to src/CodeShellManager/Assets, also add it here
or it will be missing from MSI installs (portable ZIP ships everything). -->
<Component Directory="AssetsFolder" Guid="*">
<File Source="$(var.PublishDir)\Assets\terminal.html" KeyPath="yes" />
</Component>
<Component Directory="AssetsFolder" Guid="*">
<File Source="$(var.PublishDir)\Assets\terminal-transparent.html" KeyPath="yes" />
</Component>
<Component Directory="AssetsFolder" Guid="*">
<File Source="$(var.PublishDir)\Assets\terminal-init.js" KeyPath="yes" />
</Component>
<Component Directory="AssetsFolder" Guid="*">
<File Source="$(var.PublishDir)\Assets\xterm.js" KeyPath="yes" />
</Component>
Expand Down
Loading