Skip to content

Modified resampling error checking when no resampling is applied#121

Draft
jmw464 wants to merge 2 commits intoumami-hep:mainfrom
jmw464:jmw464/resampling-update
Draft

Modified resampling error checking when no resampling is applied#121
jmw464 wants to merge 2 commits intoumami-hep:mainfrom
jmw464:jmw464/resampling-update

Conversation

@jmw464
Copy link
Copy Markdown

@jmw464 jmw464 commented Feb 26, 2026

Summary

This pull request introduces the following changes

  • Circumvents check_num_jets in resampling when resampling method is None to allow for running UPP with a non specified maximum number of jets

Conformity

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.91%. Comparing base (0b441aa) to head (72e2fb1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          23       23           
  Lines        2044     2045    +1     
=======================================
+ Hits         1940     1941    +1     
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmw464 jmw464 changed the title Modified resampling error checking when no resampling is applied Draft: Modified resampling error checking when no resampling is applied Feb 27, 2026
@jmw464 jmw464 changed the title Draft: Modified resampling error checking when no resampling is applied Modified resampling error checking when no resampling is applied Feb 27, 2026
@jmw464 jmw464 marked this pull request as draft February 27, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant