Skip to content

Vendor SerialCAN for offline builds#68

Merged
IshanDutta11 merged 4 commits intoumdloop:mainfrom
dwarakeshbaraneetharan:vendor-serialcan-offline-build
Mar 12, 2026
Merged

Vendor SerialCAN for offline builds#68
IshanDutta11 merged 4 commits intoumdloop:mainfrom
dwarakeshbaraneetharan:vendor-serialcan-offline-build

Conversation

@dwarakeshbaraneetharan
Copy link
Copy Markdown
Contributor

Replaces FetchContent (which cloned SerialCAN from GitHub on every clean build) with a vendored local copy. Build no longer requires internet access

@mdurrani808
Copy link
Copy Markdown
Collaborator

Is it possible to submodule this? Do we need the entire thing in source?

@dwarakeshbaraneetharan
Copy link
Copy Markdown
Contributor Author

Is it possible to submodule this? Do we need the entire thing in source?

We could submodule it, but vendoring is more reliable as submodules break without --recurse-submodules, and if we ever need to re-clone on the Jetson in the field we'd need internet. Vendoring pins us to a known-working commit and it's only 2.9MB and we already vendor bigger things like the ZED wrapper and CTRE Phoenix headers. We don't need the full source tree though I can trim it down drop the examples/tests/docs if you want.

Copy link
Copy Markdown
Contributor

@IshanDutta11 IshanDutta11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, did a quick benchmark with my virtual machine's connection turned off for the original repo and your branch and now it seems to build without needing a connection.

@IshanDutta11 IshanDutta11 merged commit 18184dd into umdloop:main Mar 12, 2026
1 check passed
mdurrani808 added a commit that referenced this pull request Apr 7, 2026
Co-authored-by: Mohammad Durrani <46766905+mdurrani808@users.noreply.github.com>
Co-authored-by: IshanDutta11 <49695896+IshanDutta11@users.noreply.github.com>
a-cires pushed a commit to a-cires/athena-code that referenced this pull request Apr 13, 2026
Co-authored-by: Mohammad Durrani <46766905+mdurrani808@users.noreply.github.com>
Co-authored-by: IshanDutta11 <49695896+IshanDutta11@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants