Conversation
Apply the NEXT_LOCALE cookie on the client (lang/dir + translated hero copy) on prerendered pages, and add src/lib/i18n.ts message catalogs plus middleware. This makes ar/ur render RTL correctly, so the Playwright e2e suite is reliable again — drop continue-on-error from the E2E Tests job.
…ocking
The app is SSR (output: 'server', @astrojs/vercel) so there is no ./dist
for LHCI's staticDistDir. Mark the four audited landing pages
prerender=true so `pnpm build` emits their static HTML into
.vercel/output/static, which LHCI serves directly — deterministic, no
running server needed. Fix the two SEO/a11y defects the gate surfaced
(legible font size, descriptive link text), then drop continue-on-error
so the perf/a11y/SEO score gate (minScore 0.95) is blocking again.
- web/lighthouserc.cjs: staticDistDir -> .vercel/output/static, runs 1->3
- web/src/components/DisclaimerBanner.astro: font 0.72->0.75rem; link text
"Learn more" -> "Read our Sharia content guidelines"
- web/src/pages/{dawah,donate,legal/sharia-disclaimer}: prerender=true
(index.astro prerender landed in the preceding i18n commit)
- .github/workflows/_reusable-lighthouse.yml: remove continue-on-error
- web/.gitignore: ignore .lighthouseci/
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🟢 Rampart Security Gate — CLEAN
Totals: 0 critical · 0 high · 0 medium · 0 low Mode: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
staticDistDir: './dist'against anoutput: 'server'app with no dist)./,/dawah,/donate,/legal/sharia-disclaimer) are nowprerender = true, sopnpm buildemits their static HTML into.vercel/output/static, which LHCI serves viastaticDistDir. Deterministic, no running server needed. This is also a production win (CDN-cached HTML vs SSR per request).DisclaimerBanner.continue-on-error: truefrom the Run Lighthouse CI step — the perf/a11y/SEO score gate (minScore 0.95) is blocking again.ci.yml).Local verification (exact CI toolchain:
@lhci/cli@0.13.x)//dawah//donate//legal/sharia-disclaimer/Build, typecheck, lint, unit tests, and Playwright e2e (chromium, 17 passed / 1 skipped) all green locally.