ci(chatislam): make a11y-axe workflow functional (chromedriver match + contrast fixes) - #22
Merged
Merged
Conversation
The @axe-core/cli bundled chromedriver tracks latest Chrome stable and mismatched the runner's pre-installed Chrome (exit 2). Install the matching driver via nanasess/setup-chromedriver and point axe at it; also pin the bundled chromedriver package via CHROMEDRIVER_FILEPATH as a fallback. Fix the two WCAG AA color-contrast violations this now surfaces: - disclaimer link mid-green (3.6:1) -> light-green (6.1:1) - footer copyright opacity 0.4 (3.1:1) -> 0.7 (6.4:1) Drop the homepage --include scope so the footer is actually audited.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🟢 Rampart Security Gate — CLEAN
Totals: 0 critical · 0 high · 0 medium · 0 low Mode: |
axe now runs on /chat and surfaced 4 real issues: - queries-remaining + empty-state + powered-by text: brand-green-mid/low opacity on dark panels (2.8-4.1:1) -> light-green / opacity 0.7 (>=6:1) - Turnstile wrapper: aria-label on roleless div -> add role=group Note: the queries-remaining warning color #ff9966 (shown only at <=1 query left) is ~3.7:1 on the dark panel; left as an intentional alert color.
Contributor
Author
|
✅ Verified on CI — the a11y-axe gate is now functional.
Before this PR the step died with exit 2 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The advisory
a11y-axegate never actually ran axe. After two prior fixes (dev-server start, removed invalid--reporter),@axe-core/clistill failed: its bundled chromedriver tracks the latest Chrome stable and mismatched the runner's pre-installed Chrome (exit 2 — "This version of ChromeDriver only supports Chrome version N").Fix
nanasess/setup-chromedriver@v3— auto-installs the ChromeDriver matching the runner's Chrome at/usr/local/bin/chromedriver.--chromedriver-pathto bothaxecalls; pin the bundledchromedrivernpm package viaCHROMEDRIVER_FILEPATHas a fallback for the known--chromedriver-pathignored bug.--chrome-options(no-sandbox, disable-dev-shm-usage).Contrast fixes (real WCAG 2.1/2.2 AA failures axe now surfaces)
Also dropped the homepage
--includescope so the<footer>is actually audited.Gate stays
continue-on-error: true(advisory until P4 baselines).