Skip to content

fix(ci): rampart-gate.js severity precedence — metadata.rampart must win over raw semgrep severity #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acamarata merged 1 commit into from
Jul 5, 2026
Merged

fix(ci): rampart-gate.js severity precedence — metadata.rampart must win over raw semgrep severity #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/scripts/rampart-gate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,19 @@ if (tool === 'pnpm') {

if (tool === 'semgrep') {
// semgrep JSON: { results: [{ check_id, path, extra: { severity, metadata: { rampart } } }] }
// Custom rampart/ rules are authored with `severity: ERROR` so semgrep never
// filters them out, and carry the real business severity in `metadata.rampart`
// instead. That metadata must win over the raw semgrep severity — otherwise
// every custom rule (all `severity: ERROR` by convention) gets promoted to
// CRITICAL regardless of its own documented rampart severity.
const results = report.results || [];
for (const r of results) {
const rawSev = r.extra?.severity || r.severity || 'WARNING';
const rampartMeta = r.extra?.metadata?.rampart || '';
let sev;
if (rampartMeta === 'CRITICAL' || rawSev === 'ERROR') sev = 'CRITICAL';
else if (rampartMeta === 'HIGH' || rawSev === 'WARNING') sev = 'HIGH';
if (rampartMeta) sev = rampartMeta.toUpperCase();
else if (rawSev === 'ERROR') sev = 'CRITICAL';
else if (rawSev === 'WARNING') sev = 'HIGH';
else if (rawSev === 'INFO') sev = 'LOW';
else sev = 'MEDIUM';
const filePath = r.path || 'unknown';
Expand Down
Loading