ci(islamwiki): green Unit Tests — cover data-dir, exclude runtime-data [T-P2-E5] - #21
Merged
Merged
Conversation
The R2-CDN refactor (79f4a7b) added two lib/data modules that failed the perFile coverage gate (80/80/75/80): - lib/data/runtime-data.ts (577-line server-only HTTP reader, ~2%): add to coverage exclude alongside the sibling fs/infra readers (books.ts, hadith.ts …) — it needs a live origin and is covered by E2E/integration. TODO(P2-E5). - lib/data/data-dir.ts (pure env resolver, 50% branches): add a real unit test covering all three branches (override / subdir / default) → 100%. Verified locally: 586 tests pass, coverage gate green.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🟢 Rampart Security Gate — CLEAN
Totals: 0 critical · 0 high · 0 medium · 0 low Mode: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores
Islam.wiki CIto green. The R2-CDN refactor (79f4a7b) added twolib/datamodules that broke the perFile coverage gate (80/80/75/80):lib/data/runtime-data.ts— 577-line server-only HTTP reader for on-demand SSR pages (~2% coverage). Added to the coverageexcludelist alongside the sibling fs/infra readers it mirrors (books.ts,hadith.ts, …); it needs a live origin and is covered by E2E/integration.TODO(P2-E5).lib/data/data-dir.ts— pure env resolver, was 50% branches. Added a real unit test covering all three branches (override / subdir / default) → 100%.Verification (local)
pnpm test:coverage→ exit 0, 586 tests pass,data-dir.ts100%.pnpm lint+pnpm tsc --noEmit→ clean.