Skip to content

fix(settings): fit the Interface and Agent Status tabs in the window #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umputun merged 1 commit into from
Sep 11, 2026
Merged

fix(settings): fit the Interface and Agent Status tabs in the window #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/rules/settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ paths:
contract, so freeing it risks a crash and the rare leak is accepted.
- `.agtermAppearanceChanged` is required because terminal color is not observable; it updates
`terminalColor`, quick-terminal backing, title/window appearance, and non-observable chrome mirrors.
- Settings is a 540x640 six-tab SwiftUI scene with explicit selection defaulting General, preventing
- Settings is a 540x680 six-tab SwiftUI scene with explicit selection defaulting General, preventing
`com_apple_SwiftUI_Settings_selectedTabIndex` persistence. General holds Mouse, Sessions, and Ghostty
Config. Appearance holds Terminal and Window. Interface groups `InterfaceElement`s two per row, plus
Multiple Windows and the quick terminal's panel size, which sits there rather than under Appearance's
Expand Down
5 changes: 2 additions & 3 deletions agterm/Views/SettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ struct SettingsView: View {
.tabItem { Label("Key Mapping", systemImage: "keyboard") }
.tag(Tab.keyMapping)
}
.frame(width: 540, height: 640)
.frame(width: 540, height: 680)
// without this a process-launch reopen (see agtermApp's FB11763863 workaround) resurrects a stale
// Settings window on its last tab, stealing key focus from the real launch window.
.background(NonRestorableWindow())
Expand Down Expand Up @@ -446,7 +446,7 @@ private struct AppearanceSettingsView: View {
}

/// Interface tab: per-element title-bar and sidebar chrome visibility, grouped by surface, two toggles per
/// row so the tab keeps fitting the fixed 540×640 window as the element set grows, plus the quick terminal's
/// row so the tab keeps fitting the fixed 540×680 window as the element set grows, plus the quick terminal's
/// panel size — that panel belongs to no window, so it is not a Window setting. Everything shows by
/// default; a toggle off adds it to `AppSettings.hiddenInterfaceElements` and live-applies — title-bar and
/// footer elements re-gate in open windows on `.agtermAppearanceChanged`, the add-session "+" on hover.
Expand Down Expand Up @@ -631,7 +631,6 @@ private struct AgentStatusSettingsView: View {
Text("Disabled").tag(StatusReset.never)
}
.accessibilityIdentifier("settings-status-clear")
SettingHint("When typing into a blocked or completed session clears its status.")
}

Section("Auto-follow") {
Expand Down
Loading