docs(cookbook): correct the PATH a custom command runs with in window-switcher README - #600
Open
anadale wants to merge 1 commit into
Open
docs(cookbook): correct the PATH a custom command runs with in window-switcher README#600anadale wants to merge 1 commit into
anadale wants to merge 1 commit into
Conversation
…-switcher README The Setup paragraph said a keymap command runs under launchd's bare PATH, so agtermctl only resolves through Help > Install Command Line Tool and a Homebrew jq needs its absolute path. Wrong since 0.22.0 (umputun#395): CommandPath.widened adds the bundled agtermctl directory, /usr/local/bin and /opt/homebrew/bin, so both resolve on their own. Pointed out in the umputun#599 review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the #599 review.
cookbook/window-switcher/README.md:47claimed a keymap command runs under launchd's barePATH, soagtermctlresolves only via Help ▸ Install Command Line Tool… and a Homebrewjqneeds its absolute path. That is wrong for every version the recipe supports: since 0.22.0 (#395)CommandPath.widenedadds the bundledagtermctldirectory,/usr/local/binand/opt/homebrew/bin.The paragraph now says the chord runs under the app's GUI
PATHwith the bundled CLI and the Homebrew bin on it, that only what the shell profile adds is out of reach, and keepsAGTERMCTLfor an unusual location. Script and index untouched.