Skip to content

build: move main package to app/revdiff so go install yields revdiff - #360

Merged
umputun merged 1 commit into
masterfrom
go-install-revdiff-binary
Sep 14, 2026
Merged

umputun merged 1 commit into
masterfrom
go-install-revdiff-binary

Conversation

@umputun

@umputun umputun commented Sep 14, 2026

Copy link
Copy Markdown
Owner

go install github.com/umputun/revdiff/app@latest produced a binary named app, since Go names it after the last path element. The main package moves to app/revdiff/, so go install github.com/umputun/revdiff/app/revdiff@latest produces revdiff. Every other package stays under app/.

--version printed unknown on that path because go install skips the Makefile ldflags. It now falls back to the module version from build info when available.

README, site docs and both plugin install references gain the go install command. @latest picks up the new path with the next tag.

Fix #359

Copilot AI lite review requested due to automatic review settings September 14, 2026 04:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

`go install` produced a binary named `app`, because Go names it after the last path element. All other packages stay under `app/`.

go installs skip the Makefile ldflags, so `--version` printed `unknown` on that path. It now uses the module version from build info when no revision was injected.

Fix #359
@umputun
umputun force-pushed the go-install-revdiff-binary branch from 70f9313 to 4460768 Compare September 14, 2026 04:33
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 14, 2026

Copy link
Copy Markdown

Deploying revdiff with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4460768
Status: ✅  Deploy successful!
Preview URL: https://6f7ae329.revdiff.pages.dev
Branch Preview URL: https://go-install-revdiff-binary.revdiff.pages.dev

View logs

@umputun
umputun merged commit d077e6f into master Sep 14, 2026
5 checks passed
@umputun
umputun deleted the go-install-revdiff-binary branch September 14, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go installation creates app instead of revdiff

2 participants