Skip to content

ci: migrate ci_security and ci_scheduled to org-infra reusable workflows - #43

Merged
yvonnedevlinrh merged 3 commits into
mainfrom
opsx/fix-ci-security-reusable-migration
Sep 3, 2026
Merged

ci: migrate ci_security and ci_scheduled to org-infra reusable workflows#43
yvonnedevlinrh merged 3 commits into
mainfrom
opsx/fix-ci-security-reusable-migration

Conversation

@yvonnedevlinrh

@yvonnedevlinrh yvonnedevlinrh commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Replaces the inline osv-scanner and scorecard-action steps in ci_security.yml and ci_scheduled.yml with calls to the complytime/org-infra reusable workflows. Both files were pinning action SHAs that no longer resolve upstream, causing hard CI failures on every PR and every nightly cron run.

  • ci_security.ymlreusable_vuln_scan.yml + reusable_security.yml
  • ci_scheduled.ymlreusable_scheduled.yml

Both files are now pinned at 0c784711 # v0.7.1, matching unbound-force/unbound-force and complytime/.github.

Related Issues

Review Hints

  • The OSV action changed form between v2.0.x and v2.5.x — it moved from an inline step to a reusable workflow caller. A previous attempt to fix this (commit 89ea9d7) was reverted because only the SHA was bumped without the structural change. This PR handles both.
  • packages: write and id-token: write on call_reusable_vuln_scan are required by the reusable even when Trivy image scanning is disabled — omitting them causes a runtime permission error.
  • ci_checks.yml is intentionally not migrated — its inline Go lint/test jobs are repo-specific and not covered by reusable_ci.yml.
  • ci_dependencies.yml is covered separately by issue chore: replace inline dependency-review-action with org-infra reusable workflows #41

Known Issues

  • Dependency Review — pre-existing failure, unblocked once issue chore: replace inline dependency-review-action with org-infra reusable workflows #41 is resolved
  • Scorecard (security-events: write on ci_scheduled.yml) — one-time new-alert from GitHub code scanning; reusable_scheduled.yml requires this permission for SARIF upload and matches complytime/.github exactly. Will not appear on future PRs once this is on main

This PR was generated by /uf.finale (AI-assisted).

Replace inline osv-scanner and scorecard-action steps (both using dead
SHAs) with calls to complytime/org-infra reusable workflows:

- ci_security.yml: reusable_vuln_scan.yml + reusable_security.yml
- ci_scheduled.yml: reusable_scheduled.yml

Pins org-infra at 0c784711 (v0.7.1), matching unbound-force/unbound-force
and complytime/.github. Resolves the OSV-Scanner and OpenSSF Scorecards
hard-fails on PR #40.

Closes #NNN
- Add <!-- code-review: passed --> marker to tasks.md
- Add openspec/config.yaml (schema: spec-driven) generated by CLI

Assisted-by: claude-sonnet
Generated with AI assistance (claude-sonnet)
@yvonnedevlinrh yvonnedevlinrh added the enhancement New feature or request label Sep 2, 2026
@yvonnedevlinrh yvonnedevlinrh moved this to Ready for Review 👀 in Unbound Force Planning Sep 2, 2026
@yvonnedevlinrh yvonnedevlinrh self-assigned this Sep 2, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Comment thread .github/workflows/ci_scheduled.yml Dismissed
Comment thread .github/workflows/ci_security.yml Fixed
reusable_vuln_scan.yml does not require packages: write or id-token: write
when enable_trivy_source: false. Aligns ci_security.yml permissions
exactly with complytime/.github, eliminating the Scorecard code-scanning
alert on PRs.

Assisted-by: claude-sonnet
Generated with AI assistance (claude-sonnet)
@yvonnedevlinrh

Copy link
Copy Markdown
Contributor Author

Merge this first — it unblocks #44

This PR fixes the dead-SHA failures that are currently red on main (and therefore on every open PR, including #44):

google/osv-scanner-action@e5012758…  → unable to find version
ossf/scorecard-action@05b42c62…      → unable to find version

On this PR, the migrated checks pass ✅

  • OSV-Scanner / OSV-Scanner / osv-scan → pass
  • OpenSSF Scorecards / OpenSSF Scorecards → pass

The two red checks still shown here — Dependency Review and Scorecard — are the legacy inline jobs from main running against this PR (the old dependency-review-action hard-fail and the old dead-SHA scorecard). They disappear from main once this PR merges; they are not produced by the new code in this PR.

Merge order

  1. Merge this PR (ci: migrate ci_security and ci_scheduled to org-infra reusable workflows #43) first — restores green security workflows on main.
  2. Then rebase/update fix: migrate ci_dependencies to org-infra reusable workflows #44 (fix: migrate ci_dependencies…) on the new main; its inherited OSV/Scorecard failures will clear.

Minor note: this PR and #44 both add openspec/config.yaml (identical 1-line scaffold), so expect a trivial, same-content conflict on that file when the second PR rebases.

@marcusburghardt marcusburghardt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvonnedevlinrh
yvonnedevlinrh merged commit f1441de into main Sep 3, 2026
9 of 11 checks passed
@yvonnedevlinrh
yvonnedevlinrh deleted the opsx/fix-ci-security-reusable-migration branch September 3, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Ready for Review 👀

Development

Successfully merging this pull request may close these issues.

chore: replace inline osv-scanner and scorecard steps with org-infra reusable workflows

4 participants