ci: migrate ci_security and ci_scheduled to org-infra reusable workflows - #43
Conversation
Replace inline osv-scanner and scorecard-action steps (both using dead SHAs) with calls to complytime/org-infra reusable workflows: - ci_security.yml: reusable_vuln_scan.yml + reusable_security.yml - ci_scheduled.yml: reusable_scheduled.yml Pins org-infra at 0c784711 (v0.7.1), matching unbound-force/unbound-force and complytime/.github. Resolves the OSV-Scanner and OpenSSF Scorecards hard-fails on PR #40. Closes #NNN
- Add <!-- code-review: passed --> marker to tasks.md - Add openspec/config.yaml (schema: spec-driven) generated by CLI Assisted-by: claude-sonnet Generated with AI assistance (claude-sonnet)
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
reusable_vuln_scan.yml does not require packages: write or id-token: write when enable_trivy_source: false. Aligns ci_security.yml permissions exactly with complytime/.github, eliminating the Scorecard code-scanning alert on PRs. Assisted-by: claude-sonnet Generated with AI assistance (claude-sonnet)
Merge this first — it unblocks #44This PR fixes the dead-SHA failures that are currently red on On this PR, the migrated checks pass ✅
The two red checks still shown here — Dependency Review and Scorecard — are the legacy inline jobs from Merge order
Minor note: this PR and #44 both add |
Summary
Replaces the inline
osv-scannerandscorecard-actionsteps inci_security.ymlandci_scheduled.ymlwith calls to thecomplytime/org-infrareusable workflows. Both files were pinning action SHAs that no longer resolve upstream, causing hard CI failures on every PR and every nightly cron run.ci_security.yml→reusable_vuln_scan.yml+reusable_security.ymlci_scheduled.yml→reusable_scheduled.ymlBoth files are now pinned at
0c784711 # v0.7.1, matchingunbound-force/unbound-forceandcomplytime/.github.Related Issues
Review Hints
89ea9d7) was reverted because only the SHA was bumped without the structural change. This PR handles both.packages: writeandid-token: writeoncall_reusable_vuln_scanare required by the reusable even when Trivy image scanning is disabled — omitting them causes a runtime permission error.ci_checks.ymlis intentionally not migrated — its inline Go lint/test jobs are repo-specific and not covered byreusable_ci.yml.ci_dependencies.ymlis covered separately by issue chore: replace inline dependency-review-action with org-infra reusable workflows #41Known Issues
security-events: writeonci_scheduled.yml) — one-time new-alert from GitHub code scanning;reusable_scheduled.ymlrequires this permission for SARIF upload and matchescomplytime/.githubexactly. Will not appear on future PRs once this is onmainThis PR was generated by /uf.finale (AI-assisted).