fix: address review-council findings and boostrap uf - #10
Merged
jpower432 merged 3 commits intoSep 3, 2026
Conversation
Migration guidance (CHANGELOG), missing removed-field test fixtures (personas, workflow), macOS-safe sed in provision.sh, schema validation gate on publish-cue.yml, specific cue vet error output in task test, globbed vet-examples, and stale open_question rename in prd-curator.md. Assisted-by: Claude Code <noreply@anthropic.com> fix: address review council findings on prior commit - provision.sh: fix ERR trap referencing stale/unset $clean across loop iterations (could rm -rf an unrelated already-finished case); also clean up .gitconfig and clear the trap after the loop - Taskfile.yml: drop sources:-based caching on vet-examples — it was silently skipping re-validation on unchanged example files even after schema edits, defeating the task's purpose - CHANGELOG.md: clarify the breaking schema change already shipped in unbound-force#8, this entry backfills documentation rather than describing a pending change - prd-curator.md: fix subject/verb mismatch from the open-questions rename ("open-questions entry", not bare plural as subject) Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432
marked this pull request as ready for review
September 2, 2026 19:59
jflowers
approved these changes
Sep 3, 2026
jflowers
left a comment
jflowers
left a comment
Contributor
There was a problem hiding this comment.
PR Review: #10
Verdict: APPROVE
Well-executed remediation of #7 review-council findings plus uf init scaffolding. Intentional changes (provision.sh safety, CI validation gate, fixtures, CHANGELOG, schema comment) match the stated findings.
Alignment
No issues found.
Security
- [LOW]
.gitignore:27—openspeclacks trailing/(inline comment). - [LOW]
.github/workflows/publish-cue.yml— no top-levelpermissions: {}deny-all (unlikeci.yml). Job-level perms are set; CI-020 prefers deny-all at workflow level. Not inline because that line is outside the diff hunk.
Constitution Compliance
No issues found.
CI
test PASSED.
This review was generated by /uf.review-pr (AI-assisted).
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> Co-authored-by: Jay Flowers <jay.flowers@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses findings from #7 that were merged in #6 and runs
uf initRelated Issues
Refs: #7
Review Hints
review-councilrun locally to while adressing changesUsed latest uf release with AI-assisted
uf-init