fix(core-users): distinguish validation error reasons for email and u…#692
Open
networkinss wants to merge 2 commits intounchainedshop:masterfrom
Open
fix(core-users): distinguish validation error reasons for email and u…#692networkinss wants to merge 2 commits intounchainedshop:masterfrom
networkinss wants to merge 2 commits intounchainedshop:masterfrom
Conversation
…sername Default validators returned false for both invalid format and duplicate entry. Callers threw a single generic error for both, causing the Admin UI to show a misleading message even when the real problem was a duplicate. defaultValidateEmail and defaultValidateUsername now return a typed ValidationResult object instead of a boolean. The four call sites in configureUsersModule propagate the specific reason as the Error cause: EMAIL_FORMAT_INVALID, EMAIL_ALREADY_EXISTS, USERNAME_TOO_SHORT, USERNAME_ALREADY_EXISTS. errors.ts gains EmailFormatInvalidError and UsernameTooShortError, and the previously merged messages on EmailAlreadyExistsError and UsernameAlreadyExistsError are made specific.
Return { valid: true } instead of a bare boolean to match the
ValidationResult type introduced by fix/distinguish-validation-error-reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sername
Default validators returned false for both invalid format and duplicate
entry. Callers threw a single generic error for both, causing the Admin
UI to show a misleading message even when the real problem was a duplicate.
defaultValidateEmail and defaultValidateUsername now return a typed
ValidationResult object instead of a boolean. The four call sites in
configureUsersModule propagate the specific reason as the Error cause:
EMAIL_FORMAT_INVALID, EMAIL_ALREADY_EXISTS, USERNAME_TOO_SHORT,
USERNAME_ALREADY_EXISTS.
errors.ts gains EmailFormatInvalidError and UsernameTooShortError,
and the previously merged messages on EmailAlreadyExistsError and
UsernameAlreadyExistsError are made specific.