Skip to content

fix: no-types.d.ts not being published - #687

Merged
Brentlok merged 1 commit into
mainfrom
fix/missing-no-types
Sep 23, 2026
Merged

Brentlok merged 1 commit into
mainfrom
fix/missing-no-types

Conversation

@Brentlok

@Brentlok Brentlok commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Package Compatibility
    • Component subpath imports now have a published declaration placeholder, improving compatibility for projects that use package type resolution.
  • Documentation
    • Updated package boundary documentation to reflect the published component declaration.

@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge and directly resolves the missing declaration artifact in published packages.

Summary

This PR fixes the published uniwind package contents by including the placeholder declaration referenced by component subpath exports.

  • Adds no-types.d.ts to the package allowlist.
  • Documents the declaration artifact in CONTEXT.md.
  • Places the root types export before the style condition.

Reviews (1) · Last reviewed commit: "fix: no-types.d.ts not being published"

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d8bc0758-11bf-4cbc-a4f7-51281cbed069

📥 Commits

Reviewing files that changed from the base of the PR and between 31d91fc and 1c67e4c.

📒 Files selected for processing (2)
  • CONTEXT.md
  • packages/uniwind/package.json

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The package manifest adds no-types.d.ts to the published files and reorders the types and style conditions without changing their paths. The package boundary documentation describes the declaration’s role in component subpath exports.

Changes

Component declarations

Layer / File(s) Summary
Package publication metadata
packages/uniwind/package.json, CONTEXT.md
The package includes no-types.d.ts in its published files. The documentation identifies it as the placeholder declaration for component subpath exports. The types and style conditions retain their existing paths.

Priority: ⚪ Not assessed

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 1c67e

The package now includes the placeholder declaration used by its component subpath exports. No concrete merge-blocking risk was established; the change is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: publishing the missing no-types.d.ts file. It is concise and directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Brentlok
Brentlok merged commit c7978fd into main Sep 23, 2026
3 checks passed
@Brentlok
Brentlok deleted the fix/missing-no-types branch September 23, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant