Fix 1.15.0 post-merge Release validation

.github/workflows/pull-request.yaml

@@ -53,8 +53,8 @@ jobs:
         run: dotnet test ${{ env.SOLUTION_PATH }} -c ${{ env.CONFIGURATION }} --no-build --no-restore --logger trx
       - name: Restore HDB01 BerkeleyDb tests
         run: dotnet restore ${{ env.BERKELEYDB_TEST_PROJECT }}
-      - name: Test HDB01 BerkeleyDb package foundation
-        run: dotnet test ${{ env.BERKELEYDB_TEST_PROJECT }} -c ${{ env.CONFIGURATION }} --no-restore --logger trx -p:ContinuousIntegrationBuild=true
+      - name: Test BerkeleyDb release configuration
+        run: dotnet test ${{ env.BERKELEYDB_TEST_PROJECT }} -c Release --no-restore --logger trx -p:ContinuousIntegrationBuild=true
       - name: Pack coordinated Staging packages
         if: matrix.package_host
         shell: pwsh

tests/Icod.TermInfo.BerkeleyDb.Tests/src/Hdb05CatalogReaderTests.cs

@@ -679,10 +679,10 @@ public void EmptyDatabaseReturnsAnEmptyImmutableSnapshot() {
 	}
 
 	[Fact]
-	public void ConcurrentReadsUseIndependentLimitSnapshots() {
-		WithDatabase(
+	public async Task ConcurrentReadsUseIndependentLimitSnapshots() {
+		await WithDatabaseAsync(
 			CreateCatalogStore( "sample", "sample-alias" ),
-			path => {
+			async path => {
 				BerkeleyDbTerminalCatalogReader accepted =
 					new(
 						path,
@@ -700,15 +700,15 @@ public void ConcurrentReadsUseIndependentLimitSnapshots() {
 
 				Task<IReadOnlyList<BerkeleyDbTerminalCatalogEntry>> success =
 					Task.Run( () => accepted.Read() );
-				Task<Exception?> failure =
+				Task<Exception> failure =
 					Task.Run(
 						() => Record.Exception( () => rejected.Read() )
 					);
-				Task.WaitAll( success, failure );
+				await Task.WhenAll( success, failure );
 
-				Assert.Equal( 2, success.Result.Count );
+				Assert.Equal( 2, ( await success ).Count );
 				Assert.IsType<BerkeleyDbDatabaseFormatException>(
-					failure.Result
+					await failure
 				);
 			}
 		);
@@ -1014,6 +1014,19 @@ Action<string> assertion
 		}
 	}
 
+	private static async Task WithDatabaseAsync(
+		byte[] database,
+		Func<string, Task> assertion
+	) {
+		string path = Path.GetTempFileName();
+		try {
+			File.WriteAllBytes( path, database );
+			await assertion( path );
+		} finally {
+			File.Delete( path );
+		}
+	}
+
 	private static void WithTwoDatabases(
 		byte[] first,
 		byte[] second,

tests/Icod.TermInfo.BerkeleyDb.Tests/src/Hdb07LifecycleHardeningTests.cs

@@ -112,7 +112,7 @@ public void CatalogReturnsFreshSnapshotsAndHonorsPreCancellation() {
 	}
 
 	[Fact]
-	public void ConcurrentExplicitProvidersKeepResourceLimitsIndependent() {
+	public async Task ConcurrentExplicitProvidersKeepResourceLimitsIndependent() {
 		using TemporaryRoot temporary = new();
 		string path = temporary.GetPath( "limits.db" );
 		string name = "hdb07-limits";
@@ -134,7 +134,7 @@ public void ConcurrentExplicitProvidersKeepResourceLimitsIndependent() {
 				() => rejected.TryLoad( name, out _ )
 			)
 		);
-		Task.WaitAll( success, failure );
+		await Task.WhenAll( success, failure );
 
 		AssertFileCanBeOpenedExclusively( path );
 	}