Merged
Conversation
Greptile SummaryThis PR delivers a broad set of CI improvements across all five GitHub Actions workflow files, tightening reliability and correctness for the Unicon build/test/release pipeline. Key improvements:
One issue found:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Push or PR event] --> CONC{Concurrency Group}
CONC -->|cancel: true| B[build.yml]
CONC -->|cancel: true| C[packages.yml]
CONC -->|cancel: false| D[codeql.yml]
B --> W[Windows timeout 45m]
B --> M[macOS timeout 45m]
B --> L[Linux matrix timeout 45m]
B --> AL[Alpine multi-arch timeout 60m]
B --> F[Features matrix timeout 45m]
B --> FB[FreeBSD timeout 45m]
B --> DP[DebianPkg timeout 45m]
L --> GITINST[Install git in container]
GITINST --> CHECKOUT_L[Checkout]
CHECKOUT_L --> CACHE_L[Cache apt deb files]
CACHE_L --> DEPS_L[Install dependencies]
DEPS_L --> BUILD_L[Configure and Make]
BUILD_L --> TEST_L[Test]
TEST_L --> REPORT_L[TestReport - always]
REPORT_L --> UPLOAD_L[Upload Artifact - always]
D --> INSTALL_D[Install build deps]
INSTALL_D --> INIT_D[Init CodeQL]
INIT_D --> BUILD_D[Build]
BUILD_D --> SCAN[Perform Analysis timeout 180m]
PR_EVT[pull_request_target] --> LAB[Labeler v5\nsync-labels false]
Prompt To Fix All With AIThis is a comment left during a code review.
Path: .github/workflows/label.yml
Line: 17-22
Comment:
**`create-labels: false` missing — labeler will auto-create new labels**
You mentioned in the discussion that you want to control labels from GitHub and don't want the action to create new labels. With `actions/labeler@v5`, the default is `create-labels: true`, meaning any label name defined in `labeler.yml` that doesn't already exist in the repository will be **automatically created** the first time the workflow runs — this includes all the newly renamed/added labels like `uniconx`, `unicont`, `uniconc`, `runtime`, `udb`, `gui`, `ipl`, and `ci`.
`sync-labels: false` only prevents removal of manually-applied labels; it does not prevent creation of missing ones. Add `create-labels: false` to keep full control over label lifecycle:
```suggestion
- uses: actions/labeler@v5
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
sync-labels: false
create-labels: false
```
With this in place, make sure all labels referenced in `labeler.yml` already exist in the repository before merging, otherwise the labeler will silently skip applying them.
How can I resolve this? If you propose a fix, please make it concise.Last reviewed commit: acbace0 |
Member
Author
|
@greptile review |
d05c09b to
a5c31ad
Compare
Member
Author
|
@greptile review |
e4fdb89 to
e1a0f46
Compare
Member
Author
|
@greptile review |
Member
Author
|
@greptile review |
611a729 to
19d94c2
Compare
Member
Author
|
@greptile review |
Member
Author
|
@greptile review |
Member
Author
|
@greptile review |
Member
Author
|
@greptile review |
- Add concurrency blocks with cancel-in-progress: true to avoid redundant runs - Add timeout-minutes to all build jobs - Test report steps now save upload the result as an artifact - Summary steps across all jobs now have if: always() so they execute even on failure - Add fail-fast: false to the Linux jobs so one failure doesn't cancel the rest - Update actions/checkout@v3 → @v4 in the Linux and Alpine jobs Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Member
Author
|
@greptile review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.