Remove duplicate certificate chain - #8
Open
celledge wants to merge 1 commit into
Open
Conversation
sign.go: addSignerChain() was adding the chain to the list of certs twice which leads to an invalid DER set with duplicates which strict DER parsers will reject. sign_test.go: x509.SHA1WithRSA is now explicitly rejected by the Go certificate validation as insecure. The tests were failing with go 1.24. Certificates generated in the tests have been updated. The invalid signatures have been removed from TestSigs() sigalgs. Please note that verify_test.go is still using certificates with SHA1, so it no longer passes tests and will need to have those certificates replaced. I do not know where those were generated originally, so I have not fixed them in this commit. Skipping verify_test, the remaining tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sign.go:
addSignerChain()was adding the chain to the list of certs twice which leads to an invalid DER set with duplicates which strict DER parsers will reject.sign_test.go:
x509.SHA1WithRSAis now explicitly rejected by the Go certificate validation as insecure. The tests were failing with go 1.24. Certificates generated in the tests have been updated. The invalid signatures have been removed from TestSigs() sigalgs.Renamed the ExampleSignedData to TestExampleSignedData because recent versions of go require Example functions to be niladic. The function would need to be rewritten without using
t *testing.Tto remain an Example.Please note that verify_test.go is still using certificates with SHA1, so it no longer passes tests and will need to have those certificates replaced. I do not know where those were generated originally, so I have not fixed them in this commit. Skipping verify_test, the remaining tests pass.