Order anchors alphabetically#100
Draft
PeterDekkers wants to merge 2 commits into
Draft
Conversation
Contributor
|
Understand the issue, but concerned that this is a breaking change, anything that used the normalizer but didn't run through glyphs will get diffs with this change. Possible to put it behind a command line flag? If so, I'd be comfortable merging that. |
5 similar comments
Author
|
Okay, we will flesh this out a bit more, and look at putting this kind of functionality behind a Glyphs-specific flag. The ultimate goal here is to minimise UFO differences when going between Glyphs and UFO (e.g. RoboFont), and this PR was only part of the solution. |
|
also sort by anchor.x, anchor.y and anchor.color, in case there are multiple anchors with the same name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change orders anchors alphabetically, by name. It also adjusts the unit tests to check this anchor ordering.
I'm not sure if this type of ordering follows the philosophy of
ufoNormalizer, but in case it does, here is a PR that could be used.Resolves #98.