Support multiple UFOs at once#92
Open
RickyDaMa wants to merge 2 commits into
Open
Conversation
Incompatible with -o/--output Invalid/Non-existent paths are skipped, but won't cause the program to exit prematurely Add helper for tests to assert logs contain a string
RickyDaMa
force-pushed
the
multiple-ufos
branch
from
87f1685 to
a0c951f
Compare
madig
reviewed
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the CLI to support taking multiple inputs. Incompatible with
-o/--outputHappy to adjust implementation/testing as required. If there's any bad formatting let me know, I didn't see a strong standard defined anywhere and my editor's formatter was ready to eviscerate the whole file
I've tried to keep the program acting as similarly as possible - e.g. exiting with code 2 if no valid paths were provided - but also permissive, so the whole program doesn't bomb out if one input path of many is bad
Also, as far as I can see we could mark Python 3.12 as officially supported (I used it while developing/testing these changes), I can update the README & CI if you'd like :)
Finally, please consider making the repository more approachable to new contributors: https://matklad.github.io/2022/10/24/actions-permissions.html