fix: comment stripping should remove multiline comments (#279)#280
fix: comment stripping should remove multiline comments (#279)#280cjpearson wants to merge 2 commits into
Conversation
|
Thanks for the PR dear @cjpearson Removing multi-line comments without AST awareness can be unsafe this is why we don't it. See #56 for some context. Until #219 arrives, if we can find similar solution to #56 i am open to it otherwise i would wait. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 88.04% 84.08% -3.96%
==========================================
Files 8 8
Lines 1062 823 -239
Branches 188 201 +13
==========================================
- Hits 935 692 -243
- Misses 127 131 +4 ☔ View full report in Codecov by Sentry. |
|
Oh I didn't realize acorn was already in this package. I think that would be a much better way to handle comments. I'll take a look at that approach. |
b2cf9ff to
176fb90
Compare
|
I've tweaked the approach to use |
176fb90 to
c4ab502
Compare
Resolves #279