fix: revert export default class declaration entry#354
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR removes detection of ChangesRemove export default class detection
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 88.04% 83.57% -4.47%
==========================================
Files 8 7 -1
Lines 1062 487 -575
Branches 188 151 -37
==========================================
- Hits 935 407 -528
+ Misses 127 73 -54
- Partials 0 7 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This PR reverts #320, which made
findExportsreturn an extra{ type: 'declaration' }entry for default-exported classes alongside the default one.Impact on unimport
For every default-exported class, the extra entry collides with the default one in
unimport'sdedupeImports, and the wrong one wins. The generated.d.tsthen references a non-existent named export instead of.default.Source:
Before:
After:
Summary by CodeRabbit