Skip to content

changes to fetch flags from S3 - UL-916#6

Open
fahmina-ghauri wants to merge 1 commit intomainfrom
feature/UL-916
Open

changes to fetch flags from S3 - UL-916#6
fahmina-ghauri wants to merge 1 commit intomainfrom
feature/UL-916

Conversation

@fahmina-ghauri
Copy link
Contributor

No description provided.

func (f *UnlaunchFactory) sync0() Client {
hc := util.NewHTTPClient(f.sdkKey, f.cfg.Host, f.cfg.HTTPTimeout, f.logger, true)

res, err := hc.Get("https://app-qa-unlaunch-io-master-flags.s3-us-west-1.amazonaws.com")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong URL. We have different for production. You're using QA one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants