Nix stuff #183
Open
Nix stuff #183
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ The Update (preview) for UnstoppableMango/unmango-github/prod (at 55bc44d) failed. Resource Changes Name Type Operation
~ aferox unmango:github:PublicRepo refresh
~ devctl github:index/repositoryRuleset:RepositoryRuleset refresh
~ go github:index/repositoryRuleset:RepositoryRuleset refresh
~ charts github:index/repositoryRuleset:RepositoryRuleset refresh
~ cloudflare-operator github:index/repositoryRuleset:RepositoryRuleset refresh
~ gnumake-go unmango:github:PublicRepo refresh
~ protofs unmango:github:PublicRepo refresh
~ kubebuilder unmango:github:PublicRepo refresh
~ pulumi-baremetal unmango:github:PublicRepo refresh
~ thecluster unmango:github:PublicRepo refresh
~ game unmango:github:PublicRepo refresh
~ game github:index/repositoryRuleset:RepositoryRuleset refresh
~ go-pia github:index/repositoryRuleset:RepositoryRuleset refresh
~ unmango-github-prod pulumi:pulumi:Stack refresh
~ go-make github:index/repositoryRuleset:RepositoryRuleset refresh
~ gnumake-go github:index/repositoryRuleset:RepositoryRuleset refresh
~ protofs github:index/repositoryRuleset:RepositoryRuleset refresh
~ thecluster-operator github:index/repositoryRuleset:RepositoryRuleset refresh
~ go-make unmango:github:PublicRepo refresh
~ thecluster github:index/repositoryRuleset:RepositoryRuleset refresh
~ go unmango:github:PublicRepo refresh
~ cloudflare-operator unmango:github:PublicRepo refresh
~ thecluster-operator unmango:github:PublicRepo refresh
~ devctl unmango:github:PublicRepo refresh
~ kubebuilder github:index/repositoryRuleset:RepositoryRuleset refresh
~ aferox github:index/repositoryRuleset:RepositoryRuleset refresh
~ pulumi-baremetal github:index/repositoryRuleset:RepositoryRuleset refresh
~ go-pia unmango:github:PublicRepo refresh
~ charts unmango:github:PublicRepo refresh
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds Nix development environment support to the project, enabling developers to use Nix for dependency management. This provides a reproducible development environment as an alternative to the existing tooling setup.
- Introduces
shell.nixfor declarative environment configuration - Adds direnv integration through
hack/nix.envrc - Makes the Pulumi binary path overridable to support both Nix and non-Nix workflows
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| shell.nix | Defines the Nix development environment with required tools and sets PULUMI environment variable |
| hack/nix.envrc | Provides direnv configuration to automatically load the Nix environment |
| Makefile | Changes PULUMI variable assignment to allow override from Nix environment |
| .gitignore | Excludes direnv cache directory from version control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dprint | ||
| gnumake | ||
| nixfmt-tree | ||
| nodejs_24 |
There was a problem hiding this comment.
The Node.js version specified here (nodejs_24) is inconsistent with the version in .nvmrc (22.19.0). This could lead to different behavior between Nix and non-Nix development environments. Consider using nodejs_22 instead to match the version specified in .nvmrc.
Suggested change
| nodejs_24 | |
| nodejs_22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.