Repin DiffusionGemma to the commit that merges cleanly - #216
Merged
Merged
Conversation
168b21a stopped merging onto the base tag: upstream added LLM_ARCH_MAPLE to the same unsupported-saver list and the same SWA-pattern test branch that DiffusionGemma extends, so both sides edited one line and additive_merge.py correctly refused it rather than papering over it. 12e0a96 is ggml-org#24423 merged with current master, both conflicts resolved by keeping both arches. Replayed the resolve loop on b10988: the pin now merges clean.
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
d94f44e stopped merging onto the base tag: upstream hoisted the src/CMakeLists.txt source list into set(LLAMA_CORE_SOURCES ...), so the pin was still adding llama-kv-cache-kpool.cpp to an inline list that no longer exists, and MAPLE landed in the same swiglu_clamp condition GLM5NEXT extends. e2738e0 is ggml-org#27754 merged with current master. kpool now goes into LLAMA_CORE_SOURCES, which is also what drives SKIP_UNITY_BUILD_INCLUSION, so it keeps its own translation unit.
a9e9c3c was cut against base/upstream-de8656bd9 and never merged onto a newer tag: upstream reshaped the hyper-connection norms to [n_embd, hc] with TENSOR_ALLOW_RESHAPE while the pin was still changing the same lines' flags argument for its MTP head. f40f64a keeps both, upstream's shapes with the pin's flags OR-ed in. PR 144 is retargeted to base/upstream-9f31776c3 so its own diff is unchanged at 24 files.
danielhanchen
added a commit
that referenced
this pull request
Sep 16, 2026
#214 landed on glm5next/upstream after #216 was cut, so e2738e0 is no longer the head. 86ebfef is that squash on top of it: the k-pool gate logits are reshaped to 2D before ggml_soft_max so n_new_max stops mapping to gridDim.y, which CUDA caps at 65535 and which aborted the launch at n_kv >= 262144 with kpool = 4. Replayed the resolve loop on b10994 with the new pin: 11 clean, 2 additive, 0 hard fails; merge_checks clean, all 13 pins intact, llama + mtmd compile gate passed, test-llama-archs 316 rows 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The nightly stopped on the merge step in run 34907376192, before any compiling:
Upstream landed
LLM_ARCH_MAPLEin exactly the two places DiffusionGemma extends: the unsupported-arch list inllama_model_saver_supports_arch, and the alternating SWA-pattern branch intest-llama-archs.cpp. Both are add/add in meaning, but in the test the closing) {moved, so both sides edited one line andadditive_merge.pyrefused it. That refusal is correct behaviour, not a bug.What changed
12e0a962is ggml-org#24423 merged with current upstream master, with both conflicts resolved by keeping both arches:Only the pin line moves here; no build logic is touched.
Verified
Replayed the
resolvemerge loop fromunsloth-prebuilt.ymllocally againstb10988, the tag tonight's run would select:additive_merge.pyresolved them, keeping both sidesscripts/unsloth/test_additive_merge.py: 0 failuresunsloth-pr-set-lint.ymlpassesllama-diffusion-gemma-*targets,test-llama-archs -a diffusion-gemmaOK at NMSE 0.00e+00,-a mapleOK, and the full 312 row suite greenThis unblocks the merge step but not the whole release
The same replay found two further blockers behind this one, which the failed run never reached because it stopped on the first pin. Neither is caused by this change and neither is fixed here:
src/CMakeLists.txtsource list intoset(LLAMA_CORE_SOURCES ...), and the pin still addsllama-kv-cache-kpool.cppto the inline list that no longer exists. There is also a one-linellama-graph.cppconflict,MAPLEagainstGLM5NEXTin the same condition. GitHub reports the PR asmergeable: falseagainst upstream master too, and it is pinned at its current head, so there is no newer commit to repin to. It needs a rebase upstream, or the pin dropped.src/models/qwen4exp.cpp. Three conflicting hunks over the hyper-connection tensors: llama: batched readahead for lazily read gather tables #137 hashc_head_normas{n_embd, hc}withTENSOR_ALLOW_RESHAPE, MTP for Qwen3.8-Flash-Next #144 has{hc_dim}withtrunk_flags. That is a real disagreement about tensor shape, not an add/add, so nothing should auto-resolve it. One of the two needs to be updated to match the other.