test(frontend): raise vitest testTimeout to fix CI flake#63
Merged
Conversation
Build #15 on main went red on a single frontend test (HouseholdSettings > "surfaces a save error") with `Error: Test timed out in 5000ms` — backend passed and the failure never reached the Sonar stage. The test renders + does three findBy look-ups and two save clicks; locally it runs in <200ms, but the full suite (40+ files) runs in parallel worker threads and on CI's shared cores it occasionally crosses the 5s default and times out. Not a real regression (full suite is 437 green locally). Raise testTimeout/hookTimeout to 20000ms so contention can't red the build; a genuinely hung test still fails, just later. vite.config.ts is already excluded from Sonar sources (**/*.config.ts), so no new-code impact. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wr2keVNHj51gFeShnKqa7Q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #62 merged, Jenkins build #15 on
mainstill went red — but not on #62's changes and not on the SonarQube quality gate. It failed at the frontend test stage on a single test:Backend passed; because the frontend stage failed, the pipeline never reached the Sonar/Quality-Gate stage, so #62's gate fix is still unconfirmed.
That test renders
HouseholdSettings(all heavy child managers stubbed — no network I/O), then does threefindBylook-ups and two save clicks. Locally it runs in <200ms. But the full suite (40+ files) runs in parallel worker threads, and on CI's shared cores it occasionally crosses the 5000ms defaulttestTimeoutand times out. It's a load-sensitive flake, not a regression — the full suite is 437 green locally.What
Raise vitest's
testTimeout/hookTimeoutto 20000ms invite.config.ts. Generous headroom so contention can't red the build; a genuinely hung test still fails (just later).vite.config.tsalready matches the**/*.config.tsSonar exclusion, so this adds no new-code coverage/violations.Verification
HouseholdSettings.test.tsx: 7 passed (pantrie-frontendcontainer)mainbuild (new SHA) will run the suite and finally exercise the Sonar gate that chore: clear SonarQube quality-gate violations blocking main #62 cleaned up.🤖 Generated with Claude Code