feat: Add OTP login endpoints and service abstraction#233
Conversation
| return Response({}, status=403) | ||
|
|
||
|
|
||
| class OTPCallbackView(APIView): |
There was a problem hiding this comment.
I don't really see any use case for an one time password login flow besides our demo server - why is that in the core of the server?
There was a problem hiding this comment.
I thought if we can enable it on FE(It points to specific endpoints) it will be consistent to have that also implemented by default on BE side, so we have clear messages even if it's not configured. But, if you think that's redundant I can move it away from this repo. Please let me know
| const navigate = useNavigate(); | ||
| const [errorMessage, setErrorMessage] = useState<string | null>(null); | ||
| const onClick = () => { | ||
| window.location.href = `${import.meta.env.VITE_API_BASE}/api/auth/otp/start` |
There was a problem hiding this comment.
I'm a bit confused - is that SSO or OTP? These are two different concepts
There was a problem hiding this comment.
It's OTP, I need to change old button label if that's what you mean.
|
This issue has different PR: #296 |
2 participants
This PR adds endpoints to handle General OTP login and base service.
In future we should switch to using cookies with auth token for both auth methods, let me know what you think I can take care of it as we are currently doing stuff connected with auth.