Skip to content

Hi! I cleaned up your code for you! #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GunioRobot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hi! I cleaned up your code for you! #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

* current_version_from_makefilepl() now also recognizes 'reference_module'
from Module::Install::ReadmeMarkdownFromPod

0.52 (2008-05-10)

* Added VC::Git (Yann)
Expand Down
2 changes: 1 addition & 1 deletion lib/ShipIt/ProjectType/AutoConf.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ sub _build_tempdist {
# $self goes out of scope, later.
my $tdir = $self->{dist_tempdirobj} = tempdir_obj();

File::Copy::move($distfile, $tdir->directory) or
File::Copy::move($distfile, $tdir->directory) or
die "Failed to move dist $distfile to tempdir";

return $tdir->directory . "/$distfile";
Expand Down
2 changes: 1 addition & 1 deletion lib/ShipIt/ProjectType/Perl.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ sub _versioncode_from_string {
if ($string =~ /
(
( use \s* version \s* ; \s* )?
(our)? \s* \$VERSION \s* = \s*
(our)? \s* \$VERSION \s* = \s*
(
['"] [\d\.\_]+ ['"]
| q{1,2}\( \s* [\d\.\_]+ \s* \)
Expand Down
2 changes: 1 addition & 1 deletion lib/ShipIt/Util.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ sub make_var {
sub find_subclasses {
# search for any other custom project type modules
my $class = shift;
my @classes = ();
my @classes = ();
for my $dir (@INC) {
for my $file (glob("$dir/" . join("/", split(/::/, $class)) . "/*.pm")) {
if($file =~ /\/(\w+)\.pm/) {
Expand Down
2 changes: 1 addition & 1 deletion lib/ShipIt/VC.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ sub new {
return ShipIt::VC::Git->new($conf) if -e ".git";
return ShipIt::VC::Mercurial->new($conf) if -e ".hg";
return ShipIt::VC::SVK->new($conf) if $class->is_svk_co;

# look for any custom modules with an expensive search after exhausting the known ones
for my $class (grep {!/::(SVN|Git|Mercurial|SVK)$/} find_subclasses($class)) {
eval "CORE::require $class";
Expand Down
2 changes: 1 addition & 1 deletion lib/ShipIt/VC/Git.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ sub tag_version {
my $tmp_fh = File::Temp->new(UNLINK => 1, SUFFIX => '.msg');
print $tmp_fh $msg;
my $tmp_fn = "$tmp_fh";
my $tag = $self->_tag_of_version($ver);
my $tag = $self->_tag_of_version($ver);
system($self->command, "tag", "-a", ($self->{sign_tag} ? "-s" : ()), "-F", $tmp_fn, $tag)
and die "Tagging of version '$ver' failed.\n";

Expand Down