Skip to content

Update default values for combo macro#104

Open
s6t wants to merge 1 commit into
urob:mainfrom
s6t:patch-1
Open

Update default values for combo macro#104
s6t wants to merge 1 commit into
urob:mainfrom
s6t:patch-1

Conversation

@s6t
Copy link
Copy Markdown

@s6t s6t commented Feb 25, 2026

Set the default values as mentions in the official documentation (https://zmk.dev/docs/config/combos).

Set the default values as mentions in the official documentation (https://zmk.dev/docs/config/combos).
@urob
Copy link
Copy Markdown
Owner

urob commented Apr 14, 2026

Sorry for the slow response.

1/ The issue with explicitly setting the -1 default value is that Devicetree doesn't like negative integers. It's okay to leave them empty (and assign a negative default in the behavior definition). But explicitly setting negative integers via the dts results in an overflow.

Note that the current approach of setting a default of 0 for require-prior-idle-ms is functionally equivalent, as it always results in is_quick_tap being false:

https://github.com/zmkfirmware/zmk/blob/8a44ef109ae301ce084b32dd5fe25200da9e402f/app/src/combo.c#L159

2/ I don't have a strong opinion on the timeout default, but it would be a breaking change. So it's not clear to me that changing it provides enough of an upside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants