Skip to content

Toast error #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shreykrishnatray wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Toast error #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b8dcab
made required changes in AttendeeInput.tsx
Shreykrishnatray Oct 15, 2025
29c5ec1
made required changes in login-index.tsx
Shreykrishnatray Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 57 additions & 61 deletions client/src/components/AttendeeInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ export default function AttendeeInput({ id, onChange, value, type }: AttendeeInp
};

const handleSelectionChange = (_: React.SyntheticEvent, newValue: Array<string | IPeopleInformation>) => {
const emails = newValue.map((option) => (typeof option === 'object' && option.email ? option.email : (option as string)));
const emails = newValue.map((option) =>
typeof option === 'object' && option.email ? option.email : (option as string)
);
const filteredEmails = emails
.join(' ')
.split(/\s+/)
Expand All @@ -44,7 +46,9 @@ export default function AttendeeInput({ id, onChange, value, type }: AttendeeInp

uniqueEmails.forEach((email) => {
if (isEmailValid(email)) {
const existingPerson = newValue.find((option) => typeof option === 'object' && option.email === email) as IPeopleInformation;
const existingPerson = newValue.find(
(option) => typeof option === 'object' && option.email === email
) as IPeopleInformation;
if (existingPerson) {
validPeople.push(existingPerson);
} else {
Expand All @@ -63,45 +67,54 @@ export default function AttendeeInput({ id, onChange, value, type }: AttendeeInp
}
setTextInput('');
};

const debouncedInputChange = debounce(handleInputChange, 300);

return (
<Box
display="flex"
alignItems="center"
flexWrap="wrap"
sx={[
(theme) => ({
gap: '8px',
padding: '10px',
display: 'flex',
flexDirection: 'column',
borderRadius: 1,
backgroundColor: theme.palette.common.white,
'&:focus-within': {
border: 'none',
},
maxHeight: '65px',
overflowY: 'auto',
p: 1.5,
width: '100%',
boxSizing: 'border-box',
}),
]}
>
<Box
sx={{
width: '100%',
display: 'flex',
flexDirection: 'row',
alignItems: 'center',
mx: 1,
mb: 1,
}}
>
<PeopleAltRoundedIcon
sx={[
(theme) => ({
color: theme.palette.grey[50],
position: 'sticky',
top: 0,
bottom: 0,
}),
]}
sx={{
color: 'text.secondary',
mr: 1,
}}
/>
<Typography variant="subtitle1" sx={{ fontWeight: 500 }}>
Attendees
</Typography>
</Box>

{/* Scrollable list area */}
<Box
sx={{
maxHeight: { xs: '180px', sm: '250px' },
overflowY: 'auto',
WebkitOverflowScrolling: 'touch',
mb: 1,
px: 1,
pt: 0.5,
border: '1px solid #e0e0e0',
borderRadius: 1,
}}
>
<Autocomplete
multiple
options={options}
Expand Down Expand Up @@ -139,11 +152,9 @@ export default function AttendeeInput({ id, onChange, value, type }: AttendeeInp
<Avatar
alt={option.email}
src={option.photo}
sx={[
(theme) => ({
bgcolor: theme.palette.grey[50],
}),
]}
sx={{
bgcolor: 'grey.200',
}}
/>
}
variant="outlined"
Expand All @@ -160,33 +171,19 @@ export default function AttendeeInput({ id, onChange, value, type }: AttendeeInp
onChange={(e) => setTextInput(e.target.value)}
type={type}
variant="standard"
placeholder="Attendees"
slotProps={{
input: {
...params.InputProps,
endAdornment: null,
placeholder="Enter attendee emails"
fullWidth
sx={{
'& .MuiInputBase-input': {
fontSize: '0.9rem',
},
'& .MuiInput-underline:before, & .MuiInput-underline:hover:before': {
borderBottom: 'none !important',
},
'& .MuiInput-underline:after': {
borderBottom: 'none',
},
}}
sx={[
(theme) => ({
flex: 1,
py: 0,
px: 1,
'& .MuiInputBase-input': {
fontSize: theme.typography.subtitle1,
},
'& .MuiInputBase-input::placeholder': {
color: theme.palette.primary.main,
fontSize: theme.typography.subtitle1,
},
'& .MuiInput-underline:before, & .MuiInput-underline:hover:before': {
borderBottom: 'none !important',
},
'& .MuiInput-underline:after': {
borderBottom: 'none',
},
}),
]}
/>
)}
renderOption={(props, option) => {
Expand All @@ -196,21 +193,19 @@ export default function AttendeeInput({ id, onChange, value, type }: AttendeeInp
<Box
key={key}
component="li"
sx={[
(theme) => ({
'& > img': { mr: 2, flexShrink: 0 },
backgroundColor: isSelected ? theme.palette.grey[100] : 'transparent',
}),
]}
sx={{
'& > img': { mr: 2, flexShrink: 0 },
backgroundColor: isSelected ? 'grey.100' : 'transparent',
}}
{...optionProps}
gap={1}
>
<Avatar src={option.photo} alt={`Image of ${option.name}`} />
<Box sx={{ width: '80%' }}>
<Typography variant="subtitle2" noWrap={true}>
<Typography variant="subtitle2" noWrap>
{option.name}
</Typography>
<Typography variant="subtitle2" color="text.secondary" noWrap={true}>
<Typography variant="subtitle2" color="text.secondary" noWrap>
{option.email}
</Typography>
</Box>
Expand All @@ -222,3 +217,4 @@ export default function AttendeeInput({ id, onChange, value, type }: AttendeeInp
</Box>
);
}

14 changes: 10 additions & 4 deletions client/src/pages/Login/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Box, Button, Typography } from '@mui/material';
import { GoogleIcon } from '@components/CustomIcons';
import { useEffect } from 'react';
import { useLocation } from 'react-router-dom';
import { secrets } from '@config/secrets';
import toast from 'react-hot-toast';
Expand All @@ -11,9 +12,12 @@ const Login = () => {
const { state } = useLocation();
const errorMessage = state?.message;

if (errorMessage) {
toast.error(errorMessage);
}
// ✅ Show toast only once on mount when there's an error
useEffect(() => {
if (errorMessage) {
toast.error(errorMessage);
}
}, [errorMessage]);

async function onSignInClick(): Promise<void> {
await api.login();
Expand All @@ -36,6 +40,7 @@ const Login = () => {
{secrets.appSlogan}
</Typography>
</Box>

<Box sx={{ display: 'flex', flexDirection: 'column', gap: 2, mt: 4 }}>
<Box sx={{ px: isChromeExt ? 3 : 10 }}>
<Button
Expand All @@ -51,7 +56,7 @@ const Login = () => {
zIndex: 101,
'& .MuiButton-startIcon': {
marginRight: theme.spacing(3),
marginTop: theme.spacing(-0.55), // Adjusted margin
marginTop: theme.spacing(-0.55),
},
}),
]}
Expand All @@ -69,3 +74,4 @@ const Login = () => {
};

export default Login;