fix(channels): resolve outbound email recipients from metadata and reply_to - #601
Closed
s97472091-pixel wants to merge 1 commit into
Closed
fix(channels): resolve outbound email recipients from metadata and reply_to#601s97472091-pixel wants to merge 1 commit into
s97472091-pixel wants to merge 1 commit into
Conversation
…ply_to EmailChannel._resolve_target only consulted metadata["to"] and the inbound thread cache, so every outbound send failed with "email.send has no recipient for reply_to": - message tool sends set metadata["recipient"] (agentos.tools.builtin.messaging) - scheduler/heartbeat delivery pass reply_to as the recipient address Resolve the recipient from metadata["recipient"] and fall back to an email-shaped reply_to after the thread lookup (which stays first so thread keys that look like addresses still resolve to the thread). Adds regression tests for both outbound paths; existing thread-cache and refusal tests still pass. Fixes use-agent-os#598
Contributor
Author
Contributor
|
Thanks for the fix — three PRs landed on #598 with essentially the same resolution order ( I went with #695: same core change, plus it also fixes the adjacent subject bug (a brand-new outbound mail was getting Sorry for the duplicated effort. Please pick up another open issue; happy to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes outbound email sends failing with
ValueError: email.send has no recipient for reply_to.EmailChannel._resolve_target()only consultedmetadata["to"]and the inbound thread cache, so every outbound send initiated by the agent failed:agentos.tools.builtin.messaging) setmetadata["recipient"]— never checked.reply_to(e.g.alerts@example.com) — never checked.Change
Resolve the recipient in priority order:
metadata["to"](existing reply flow)metadata["recipient"](message tool)reply_toso thread keys that look like addresses still resolve to the thread)reply_towhen it parses as an email address (scheduler/heartbeat)Tests
test_send_resolves_recipient_from_metadata_recipient— message tool pathtest_send_resolves_recipient_from_reply_to_email_address— scheduler/heartbeat pathtest_email_channel.py)Fixes #598