Skip to content

chore(video-merger): enable strict shell mode in install.sh - #634

Closed
Tiktokaiagent wants to merge 1 commit into
use-agent-os:mainfrom
Tiktokaiagent:fix/525-video-merger-strict-shell
Closed

chore(video-merger): enable strict shell mode in install.sh#634
Tiktokaiagent wants to merge 1 commit into
use-agent-os:mainfrom
Tiktokaiagent:fix/525-video-merger-strict-shell

Conversation

@Tiktokaiagent

Copy link
Copy Markdown
Contributor

Summary

Every other shell script in this repository uses set -euo pipefail for safety. The video-merger install.sh was the lone outlier.

Changes

  • Switch shebang from #!/bin/bash to #!/usr/bin/env bash (matches the rest of the repo)
  • Add set -euo pipefail immediately after the shebang

Fixes #525

Switch shebang from #!/bin/bash to #!/usr/bin/env bash and add
set -euo pipefail to match the rest of the repo.

Fixes use-agent-os#525
@andreapn

Copy link
Copy Markdown
Contributor

Process note: this PR is not tracked by an open issue.

Every PR in this repository must map to one corresponding issue so we can triage, prioritise, and avoid duplicate work across contributors. The workflow is: open an issue first → wait for a maintainer to triage and label it → then open the PR that references it.

The body says Fixes #525, but #525 is already closed, so nothing on our board tracks this change. If you still think the install.sh inconsistency is worth fixing, please open an issue describing the concrete failure it causes and wait for it to be labelled before we review the PR.

@andreapn

Copy link
Copy Markdown
Contributor

Closing this PR: the issue it references, #525, is already closed, so there is nothing tracking this change.

Per the note above, please open an issue first and wait for it to be triaged and labelled before submitting a PR.

@andreapn andreapn closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants