fix(gateway): clean up empty session message subscriptions in SubscriptionManager - #637
Closed
Tiktokaiagent wants to merge 1 commit into
Closed
Conversation
…ptionManager Fixes two memory leaks: 1. unsubscribe_messages() left empty sets in _message_subs dict 2. remove_connection() didn't clean up _message_subs at all Fixes use-agent-os#609
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two memory leaks in
SubscriptionManager:unsubscribe_messages()removed conn_ids from_message_subssets but left empty set entries behind, leaking memory over time.remove_connection()iterated over_message_subs.values()and discarded conn_ids, but never cleaned up the empty sets._message_subswas not cleaned up at all — only_session_subsand_topic_subswere.Fixes #609