fix(channels): catch all TimeoutException subclasses and safely parse Retry-After in retry_request - #643
Open
tejajakarulloh wants to merge 1 commit into
Conversation
… Retry-After in retry_request
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #642
Problem
retry_request(src/agentos/channels/_util.py) has two bugs:Incomplete timeout handling — catches
(httpx.ConnectError, httpx.ReadTimeout)but missesConnectTimeout,WriteTimeout, andPoolTimeout. These are allhttpx.TimeoutExceptionsubclasses, notConnectErrorsubclasses (separate inheritance branches underTransportError). A DNS/TLS handshake timeout crashes through without retry.Unsafe
Retry-Afterparsing —float(resp.headers.get("Retry-After", ...))raisesValueErrorif the header contains an HTTP-date string (RFC 7231 §7.1.3 permits both formats).Fix
(httpx.ConnectError, httpx.ReadTimeout)to(httpx.ConnectError, httpx.TimeoutException).Retry-Afterparsing intry/except (ValueError, TypeError)with fallback to exponential backoff; clamp withmax(0.0, ...).Testing
New test file
tests/test_channels/test_channel_retry_util.pycovers:TimeoutExceptionsubclasses are retried (ConnectTimeout,ReadTimeout,WriteTimeout,PoolTimeout)ConnectErrorstill retried (unchanged behavior)Retry-Afterheader honoredRetry-Afterfalls back to backoffAll existing channel tests pass (306 passed).