fix(gateway): clean up empty session message subscriptions in Subscri… - #648
Closed
Tiktokaiagent wants to merge 1 commit into
Closed
fix(gateway): clean up empty session message subscriptions in Subscri…#648Tiktokaiagent wants to merge 1 commit into
Tiktokaiagent wants to merge 1 commit into
Conversation
…ptionManager The unsubscribe_messages method removed conn_ids from _message_subs sets but never cleaned up the empty set entries, causing a memory leak of empty sets for each session_key that had all subscribers removed. The remove_connection method had the same issue for _message_subs. Also added cleanup for _message_subs in remove_connection (previously only _session_subs and _topic_subs were cleaned up properly). Fixes use-agent-os#609
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ptionManager
The unsubscribe_messages method removed conn_ids from _message_subs sets but never cleaned up the empty set entries, causing a memory leak of empty sets for each session_key that had all subscribers removed.
The remove_connection method had the same issue for _message_subs.
Also added cleanup for _message_subs in remove_connection (previously only _session_subs and _topic_subs were cleaned up properly).
Fixes #609
Linked issue
Fixes #
says what remains.
Summary
What does this change and why?
Tests
How was this verified? Include the commands you ran and their results.