fix(memory): preserve watched file mtimes - #650
Merged
Conversation
BunnyTeddy
force-pushed
the
codex/fix-kb-source-mtime
branch
from
August 30, 2026 17:24
ec70b71 to
3c799e8
Compare
BunnyTeddy
force-pushed
the
codex/fix-kb-source-mtime
branch
from
August 31, 2026 07:58
3c799e8 to
e6f773b
Compare
BunnyTeddy
force-pushed
the
codex/fix-kb-source-mtime
branch
from
August 31, 2026 08:28
e6f773b to
a87e73f
Compare
Author
|
Addressed the accepted scope notes from #649:
I also rebased onto the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649
Summary
MemorySyncManagernow passes the filesystem mtime already captured by its watcher toLongTermMemoryStore.index_file()for both watched memory files and knowledge-base documents. This matches the direct ingestion path and keeps persisted freshness metadata and retrieval recency signals tied to the source file instead of the sync time. No extra filesystem stat is performed. Public APIs, schema, persistence, and migrations are unchanged.Tests
MEMORY.mdandknowledge_base/guide.mdwith deterministic mtimes.uv build --wheelpass.uvdoes not support the test helper's--clearflag.Diff is limited to
src/agentos/memory/sync_manager.pyandtests/test_memory_sync_manager_architecture.py.