Skip to content

WIP: Relates to Closed PR #1134 and Issue #674. Add suri_path and password_path options to CLI - #1602

Draft
ltfschoen wants to merge 7 commits into
use-ink:masterfrom
ltfschoen:luke/suri-password-file
Draft

WIP: Relates to Closed PR #1134 and Issue #674. Add suri_path and password_path options to CLI#1602
ltfschoen wants to merge 7 commits into
use-ink:masterfrom
ltfschoen:luke/suri-password-file

Conversation

@ltfschoen

@ltfschoen ltfschoen commented Apr 18, 2024

Copy link
Copy Markdown

Summary

Closes #674

  • y | Does it introduce breaking changes?
  • n | Is it dependent on the specific version of ink or pallet-contracts?

See description here #1134 (comment)

Allows user to provide either suri + password, or suri_path + password_path

Status

TODO's are included in the PR that I haven't been able to resolve, so I can't compile and update Cargo.lock

Description

Re-open PR #1134 that was previously closed.
See description here #1134 (comment)

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@cmichi

cmichi commented Nov 20, 2024

Copy link
Copy Markdown
Collaborator

@ltfschoen Sorry for such a late answer, are you up for merging master and resolving the conflicts?

@ltfschoen

Copy link
Copy Markdown
Author

@cmichi sure, i can't right at the moment though as i'm about to board a long flight. i'll have plenty of time in a couple of weeks, but i'll try and look into it asap

@ltfschoen

Copy link
Copy Markdown
Author

@ltfschoen Sorry for such a late answer, are you up for merging master and resolving the conflicts?

I've merged master and resolved the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signing: safer alternative for value bearing chains

2 participants