Upgrade to Next.js 15 and React 19#5
Open
SanjoSolutions wants to merge 7 commits intousebasejump:mainfrom
Open
Upgrade to Next.js 15 and React 19#5SanjoSolutions wants to merge 7 commits intousebasejump:mainfrom
SanjoSolutions wants to merge 7 commits intousebasejump:mainfrom
Conversation
Related GitHub issues: * dip/cmdk#245 (comment) * shadcn-ui/ui#3256
Still some places that are required to be migrated. See added TODOs.
Author
|
I have fixed the bugs that I have seen. The areas that have changed still require more testing. Maybe I set up automated tests. |
Also adds a CREDITS.md file for license compliance (I have copied some code from the documentation of the mentioned projects).
Author
|
I have tested the app manually. Everything seems to work as before. |
SanjoSolutions
changed the title
Author
|
Regarding formatting differences with most of the codebase the plan is to set-up Prettier after the merge and format the codebase automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's some work on the upgrade. There seem to be potentially still some bugs introduced which I plan to look into and fix.
Also some indirect dependencies seems to declare a peer dependency for React up to version 18 only.
This PR is related to issue #4.
Fixes #4.
useActionState
useActionStateseems to have such behavior that the form input values "reset" after form submission. I.e. when adefaultValueis set then after submission the input has thedefaultValueagain. To make it work in such way that the user changes stay in the inputs, one can use thestatethat is returned fromuseActionState. This is the basis for the change(s) regarding puttinguseActionStateoutside of theSubmitButtonand instead in the component where the form is declared, so that thestatecan be used for the the form input default values.