Skip to content

Make automatic create of personal accounts configurable#82

Open
molti-tasking wants to merge 1 commit intousebasejump:mainfrom
molti-tasking:make-automatic-creation-of-personal-accounts-configurable
Open

Make automatic create of personal accounts configurable#82
molti-tasking wants to merge 1 commit intousebasejump:mainfrom
molti-tasking:make-automatic-creation-of-personal-accounts-configurable

Conversation

@molti-tasking
Copy link
Copy Markdown

For my current projects I have to remove the feature to automatically create a "personal" space on user creation.

This merge request contains mainly:

  1. an extra boolean field for the global config to disable this feature.
  2. Also the tests crash on my end, this is why I added a if not exists check in if create extension if not exists "basejump-supabase_test_helpers" version '0.0.6';
  3. I added a new test file to check the new configuration.

Let me know what you think! :-)

@molti-tasking molti-tasking changed the title Initialize field, adapt logic, add tests Make automatic create of personal accounts configurable Apr 17, 2024
@tiniscule
Copy link
Copy Markdown
Contributor

Thanks for the PR, have been giving it some thought.

In my projects I use the personal account as a way to let the users configure things specific to their profile, not just as a billable account concept - but maybe that's murky and not the best use case.

Going to play around with this and see if I can think of any consequences to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants