fix: handle IPv6 bracketed hosts in strip_ssh_port

[devin-ai-integration]

Summary

strip_ssh_port used split_once(':') to separate host from port, which splits inside an IPv6 literal like [::1]:22 — producing a corrupt ssh://git@[/owner/repo.git.

Fix: for bracketed hosts, split on "]:"; otherwise rsplit_once(':'):

let host = if host_port.starts_with('[') {
    host_port.split_once("]:").map(|(h, _)| format!("{h}]"))?
} else {
    host_port.rsplit_once(':').map(|(h, _)| h.to_string())?
};

Adds strip_ssh_port_handles_ipv6 test.

Closes #309

Link to Devin session: https://app.devin.ai/sessions/e9a8b1c51a604a08b3642f119c1c7384
Requested by: @sachiniyer

---

---

Summary by cubic

Fixes URL parsing for SSH URLs with IPv6 bracketed hosts by correctly stripping the port without corrupting the host. Prevents malformed URLs like ssh://git@[/owner/repo.git when the input includes [::1]:22.

• Bug Fixes
  • For bracketed hosts, split on "]:", otherwise use rsplit_once(':') in strip_ssh_port.
  • Added test strip_ssh_port_handles_ipv6.

^{Written for commit 7eebc4e. Summary will update on new commits.}

[devin-ai-integration]

Original prompt from Sachin

Fix GitHub issue #309 in usedetail/cli: "Git SSH URL normalization corrupts IPv6 host when stripping port"

#``# Repository
usedetail/cli (https://github.com/usedetail/cli)

#``# Bug
In src/utils/git.rs, the strip_ssh_port function (around line 35-48) uses split_once(':') to split host from port. This breaks IPv6 bracketed hosts like ssh://git@[::1]:22/owner/repo.git because the first colon is inside the IPv6 literal [::1], producing a corrupt URL like ssh://git@[/owner/repo.git.

#``# Fix
Handle bracketed IPv6 hosts by splitting on "]:"; otherwise split on the last ::

let host = if host_port.starts_with('[') {
    host_port.split_once("]:").map(|(h, _)| format!("{h}]"))?
} else {
    host_port.rsplit_once(':').map(|(h, _)| h.to_string())?
};

#``# Requirements

1. Fix the strip_ssh_port function to correctly handle IPv6 bracketed hosts
2. Add a test for IPv6 SSH URL port stripping:

`#`[test]
fn strip_ssh_port_handles_ipv6() {
    let result = strip_ssh_port("ssh://git`@`[::1]:22/owner/repo.git");
    assert_eq!(result, Some("ssh://git`@`[::1]/owner/repo.git".to_string()));
}

3. Ensure all existing tests still pass (cargo test)
4. Ensure cargo fmt --check and cargo clippy -- -D warnings pass
5. Create a PR that closes #309

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring

[devin-ai-integration]

Devin Review found 1 potential issue.

[devin-ai-integration]

📝 Info: Behavioral change from split_once to rsplit_once in non-IPv6 path

Line 50 changes from split_once(':') to rsplit_once(':'). For valid SSH authority strings like github.com:22, these are equivalent since there is exactly one colon. The only difference would arise for malformed authorities with multiple colons (e.g. host:foo:22), where split_once would yield host=host while rsplit_once yields host=host:foo. Since such authorities are not valid URL forms and cannot match GitHub's hostname anyway, this is a safe change — but it is a subtle semantic difference worth noting.

---

Was this helpful? React with 👍 or 👎 to provide feedback.

[devin-ai-integration]

Good catch on the semantic difference. As noted, for any well-formed SSH authority there's exactly one colon separating host from port, so split_once and rsplit_once are equivalent. The switch to rsplit_once is intentional — it's the more defensive choice for the non-IPv6 path, mirroring RFC 3986's rule that the port is the segment after the last colon in the host info. Agreed this is safe.