Repository navigation
feat(s08): surface test-integrity findings in the PR body and the run webhook (default off) - #63
Merged
Merged
Conversation
…ag, default off) SHIP_TEST_INTEGRITY_SURFACING=off|shadow|on (default off; invalid is off with a log, the SHIP_BUDGET_RESERVATION contract). On: the detector's findings over the published diff reach the pull request's existing Verification section (marker-spliced, idempotent) and the run-completion webhook payload as an additive snake_case test_integrity field. Shadow: computes and logs what on would surface, writes nothing — the standing worker-path rule. Clean diffs surface nothing anywhere. No new workflow step and no recorded step result changes in any mode; the delivery record is untouched (owner approval was PR body + webhook only, programme wave-5 notes 2026-10-04). The diff analysed is the recorded repo-push diff — the same bytes the run page's advisory panel reads. Tests (src/test-integrity-surface.test.ts): default-off byte-equivalence for the section and the payload, flag-on real-path tests through verificationSection/spliceVerification/runWebhookPayload and the worker's terminal composition, negative controls (clean diff, missing/ non-string/garbage diff, invalid flag), cap and middle-cut honesty. Docs: programme wave-5 row, AUDIT_OPEN, NEXT_SESSION.
# Conflicts: # NEXT_SESSION.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening of #62 (auto-closed by an accidental branch delete; same commits c79d513+7755f0c, unchanged).
Wave-5 S08 wiring, owner-approved 2026-10-04: the test-integrity detector's findings reach the PR body and the run-completion webhook, behind a default-off flag, advisory only.
**Test integrity**part in the existing Verification section — marker-spliced, idempotent, same wording as the run-page panel, capped at 20 with a middle-cut honesty line.test_integrityfield on the terminal payload; absent on parks and when clean.Tests (src/test-integrity-surface.test.ts, 13): default-off byte-equivalence (section + webhook payload literal + worker composition spread); flag-on real-path through the actual composition code incl. oracle-edit tampered; negative controls (clean/no/garbage diff never crash or surface, invalid flag value, shadow writes nothing, cap + middle-cut).
Verification: lint clean, build clean, targeted tests green, full pnpm test 2174/2174 root (grader-sensitivity = known local port-8901 skip; CI runs it).