Skip to content

fix installer curl fallback#141

Merged
shayne-snap merged 1 commit into
mainfrom
fix/issue-137-installer-fallback
May 26, 2026
Merged

fix installer curl fallback#141
shayne-snap merged 1 commit into
mainfrom
fix/issue-137-installer-fallback

Conversation

@shayne-snap
Copy link
Copy Markdown
Contributor

@shayne-snap shayne-snap commented May 26, 2026

Summary

#137

  • fall back to Invoke-WebRequest when Windows curl.exe exists but fails during installer downloads
  • remove any partial curl output before retrying with Invoke-WebRequest

Root cause

The PowerShell installer only used Invoke-WebRequest when curl.exe was missing. On Windows environments where curl.exe uses Schannel and fails certificate revocation checks with CRYPT_E_REVOCATION_OFFLINE, the installer stopped even though Invoke-WebRequest could download the same release asset successfully.

Validation

  • git diff --check
  • make test
  • Parallels Windows 11: loaded the modified installer, injected a fake curl.exe that exits 35 and writes a partial destination file, then verified Download-File warned, retried with Invoke-WebRequest, and downloaded the real v0.1.18 checksums.txt (1292 bytes).

@shayne-snap shayne-snap marked this pull request as ready for review May 26, 2026 05:21
@shayne-snap shayne-snap merged commit 006b6ca into main May 26, 2026
2 checks passed
@shayne-snap shayne-snap deleted the fix/issue-137-installer-fallback branch May 26, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant