Update and homologate syntax #21
Open
CristopherA96 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am Cristopher,
I was recently working with this repository and had made a few small changes locally, some of these changes have been recently released, such as np.float -> float commit.
First change:
In addition to these changes, I consider that the
batch/job_template.shscript file has obsolete instructions such aspython2 "batch/train_risk_slim.py --help, since in the script you use python3 to run the tool, so when using python2 it does not works, and may cause confusion for some novice users.Second change:
In the same way, in the
solution_pool.pyfile, there are some warnings that are related to the use of the "is" syntax in python3, so checking the logic I think that "==" adapts to the functionality that you want to give with "is" syntax.These minor changes can give you a better understanding of the instructions and what is done in the repository.
As I mentioned, these are changes that for non-advanced users can cause confusion.
Thanks for your time, and I hope this will be helpful.