Skip to content

Use gulp-sass 6.0 to use modern Sass JS API #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thisisdano wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Use gulp-sass 6.0 to use modern Sass JS API #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
058337b
Use gulp-sass 6.0
thisisdano Jan 5, 2025
752dcd6
Use modern Sass API
thisisdano Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ let settings = {
},
browserslist: ["> 2%", "last 2 versions", "IE 11", "not dead"],
sassSourcemaps: true,
sassDeprecationWarnings: false
sassDeprecationWarnings: false,
},
sprite: {
width: 24,
Expand Down Expand Up @@ -123,9 +123,7 @@ const copy = {
);
return src(`${getSrcFrom("img")}/**/**`.replace("//", "/"), {
encoding: false,
}).pipe(
dest(paths.dist.img)
);
}).pipe(dest(paths.dist.img));
},
js() {
log(
Expand Down Expand Up @@ -197,8 +195,8 @@ function buildSass() {
})
.pipe(
sass({
outputStyle: "compressed",
includePaths: buildSettings.includes,
style: "compressed",
loadPaths: buildSettings.includes,
quietDeps: !settings.compile.sassDeprecationWarnings,
}).on("error", handleError)
)
Expand Down Expand Up @@ -256,7 +254,7 @@ function buildSprite() {

return src(spritePaths, {
allowEmpty: true,
encoding: false
encoding: false,
})
.pipe(svgSprite())
.pipe(rename("usa-icons.svg"))
Expand All @@ -267,7 +265,7 @@ function buildSprite() {
function renameSprite() {
return src(`${paths.dist.img}/usa-icons.svg`.replace("//", "/"), {
allowEmpty: true,
encoding: false
encoding: false,
})
.pipe(rename(`${paths.dist.img}/sprite.svg`.replace("//", "/")))
.pipe(dest(`./`));
Expand Down
9 changes: 4 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"gulp-postcss": "9.0.1",
"gulp-rename": "2.0.0",
"gulp-replace": "1.1.4",
"gulp-sass": "5.1.0",
"gulp-sass": "6.0.0",
"gulp-svgstore": "9.0.0",
"postcss": "8.4.49",
"postcss-csso": "6.0.1",
Expand Down