USWDS-Compile: Use gulp-sass v6 to use modern Sass JS API (Updated)#159
Closed
mdmower-csnw wants to merge 4 commits into
Closed
USWDS-Compile: Use gulp-sass v6 to use modern Sass JS API (Updated)#159mdmower-csnw wants to merge 4 commits into
mdmower-csnw wants to merge 4 commits into
Conversation
Contributor
Author
|
@annepetersen - Hi Anne, following up on your Slack post, you — yes, you! — can get involved, would now be a good time to nudge maintainers on this pull request, which would open the door for #145 as well? |
Contributor
|
Appreciate the nudge! This one in particular, probably not, but many others could use a hand. For context, decisions and prioritization have headed in the direction of deprecating USWDS compile rather than expending effort here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #140 since additional movement is not expected there. Several changes in that PR were only formatting, which have since been applied in
develop.Summary
Update
gulp-sassto v6.0.1 so that the new Sass v3 JS API can be used. See v6 release notes. This is a non breaking change foruswds-compileconsumers because the options API is not exposed outside of boolean optionsassDeprecationWarningswhich is used to configurequietDeps.See also migration guide from v5 to v6: https://www.npmjs.com/package/gulp-sass#migrating-to-version-6
Related issue
This is a step towards #133 but does not close that issue. A subsequent pull request can build off of this work to expose the modern options API to end users.
Problem statement
For #133, it would be best to avoid exposing the Sass options API until it is modernized, so that users do not initially configure with a deprecated API and then soon after be required to update options again for the modern API.
Solution
This pull request updates
gulp-sassto the latest v6 revision and updates internal usage of the options API.Testing and review
No observable differences should occur. This pull request is successful if no impact is noticed by consumers of
uswds-compile.Dependency updates