Test uswds-compile sassOptions#180
Draft
mdmower-csnw wants to merge 2 commits into
Draft
Conversation
Bump uswds-compile to latest commit in branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a testing pull request for uswds/uswds-compile#145 . It is not intended to be merged. Once testing is complete, this pull request can be closed.
uswds/uswds-compile#145 adds support for configuring sass-embedded via
settings.compile.sassOptions. It also deprecates but maintains compatibility forsettings.compile.sassDeprecationWarnings. Sample code changes are applied in this PR to demonstrate use of this new option.Suggested tests to get started
loadPathsand unminified CSS_site/assets/css/styles.cssshould not be minified. If the watch script is running, editing_custom.scssshould result in SASS recompilation.src/_styles/_uswds-theme-custom-styles.scss: replace@use "custom";with@use "../custom/custom";.gulpfile.js: comment out assignment ofuswds.settings.compile.sassOptions._site/assets/css/styles.cssshould be minified.gulpfile.js: addsettings.compile.sassDeprecationWarnings = true;_site/assets/css/styles.cssshould not be minified.From here, feel free to play around with additional options.