Update lifecycle-status.md#3152
Draft
amycole501 wants to merge 3 commits into
Draft
Conversation
Added new proposal status for converting to pattern
|
@amycole501 adding the preview url for your reference. |
Co-authored-by: Julia Solórzano <julia.solorzano@gsa.gov>
juliasolorzano
suggested changes
Apr 4, 2025
juliasolorzano
left a comment
juliasolorzano
left a comment
There was a problem hiding this comment.
@amycole501 added a few suggestions for your review.
I believe you will also need to add this data to the following files:
| {% assign status_classes = rejected_classes %} | ||
| {% elsif item.status_minor == "accepted" %} | ||
| {% assign status_classes = accepted_classes %} | ||
| {% elsif item.status_minor == "converting to pattern" %} |
There was a problem hiding this comment.
You need to add an assignment below this elsif statement in order for your new classname to apply. Indent two spaces and add the follow:
{% assign status_classes = lifecycle-bg--convert %}
| {% assign status_classes = rejected_classes %} | ||
| {% elsif item.status_minor == "accepted" %} | ||
| {% assign status_classes = accepted_classes %} | ||
| {% elsif item.status_minor == "converting to pattern" %} |
There was a problem hiding this comment.
Same suggestion as above:
{% assign status_classes = lifecycle-bg--convert %}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new proposal status for "Converting to pattern". Updated both mobile and desktop views.