USWDS-Site - Time Picker: Add combo box to time picker dependencies#3200
Open
IHIutch wants to merge 1 commit into
Open
USWDS-Site - Time Picker: Add combo box to time picker dependencies#3200IHIutch wants to merge 1 commit into
IHIutch wants to merge 1 commit into
Conversation
5 tasks
|
@IHIutch you've got some failing tests here too, i think both of these (#6634) are related and need to go together, if so should we combine them into one PR? |
Author
|
Hm, the failing jobs don't seem related to my changes. One looks like a Snyk config issue and it seems like the pa11y issue is related to timing out scanning the page. Might be a flaky test.. The icon page is enormous, so it might be taking too long to scan This PR and uswds/uswds#6634 are in different repos, so they can't be the same PR |
|
Ope I sure missed that this one is for the docs site. When Anne gets back next week we can poke them about the flaky tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
usa-combo-boxto time picker dependenciesRelated issue
uswds/uswds#6560
Related PR
uswds/uswds#6634
Testing and review
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch ismain).npm run prettier:scssto format any Sass updates.npm testand confirm that all tests pass.