Skip to content

USWDS-Site - Time Picker: Add combo box to time picker dependencies#3200

Open
IHIutch wants to merge 1 commit into
uswds:mainfrom
IHIutch:update-time-picker-deps
Open

USWDS-Site - Time Picker: Add combo box to time picker dependencies#3200
IHIutch wants to merge 1 commit into
uswds:mainfrom
IHIutch:update-time-picker-deps

Conversation

@IHIutch
Copy link
Copy Markdown

@IHIutch IHIutch commented May 6, 2026

Summary

Adds usa-combo-box to time picker dependencies

Related issue

uswds/uswds#6560

Related PR

uswds/uswds#6634

Testing and review

Package usage: @forward 'usa-time-picker';Dependencies: uswds-fonts, usa-label, usa-hint, usa-input, usa-combo-box
  • Create a changelog entry for any user-facing changes. Learn more about creating changelogs in _data/changelogs/_CHANGELOG-README.md.
  • Confirm that this code follows the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run git pull origin [base branch] to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch is main).
  • Run npm run prettier:scss to format any Sass updates.
  • Run npm test and confirm that all tests pass.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.

@msbtterswrth
Copy link
Copy Markdown

@IHIutch you've got some failing tests here too, i think both of these (#6634) are related and need to go together, if so should we combine them into one PR?

@IHIutch
Copy link
Copy Markdown
Author

IHIutch commented May 21, 2026

Hm, the failing jobs don't seem related to my changes. One looks like a Snyk config issue and it seems like the pa11y issue is related to timing out scanning the page. Might be a flaky test.. The icon page is enormous, so it might be taking too long to scan

This PR and uswds/uswds#6634 are in different repos, so they can't be the same PR

@msbtterswrth
Copy link
Copy Markdown

Ope I sure missed that this one is for the docs site. When Anne gets back next week we can poke them about the flaky tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants